Skip to content

Lint .strings generation in CI #8214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 2, 2022
Merged

Lint .strings generation in CI #8214

merged 4 commits into from
Dec 2, 2022

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented Nov 24, 2022 •
edited
Loading

Description

Same as wordpress-mobile/WordPress-iOS#19553 and Automattic/pocket-casts-ios#545

Adds a new CI check to give us faster feedback on whether the frozen .strings generation will work during code freeze. This way, if a PR breaks the process, we can address it immediately, without loss of context.

Testing instructions

Notice how the step passed in this build. You can see how the check catches an issue in this Jetpack/WordPress iOS demo build.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@mokagio mokagio self-assigned this Nov 24, 2022
@mokagio mokagio added the category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. label Nov 24, 2022
@mokagio mokagio added this to the 11.6 milestone Nov 24, 2022
@mokagio mokagio force-pushed the mokagio/genstrings-in-ci branch 3 times, most recently from 853547a to a22e745 Compare November 25, 2022 04:45
@mokagio mokagio force-pushed the mokagio/genstrings-in-ci branch from a22e745 to a07fa39 Compare November 25, 2022 04:51
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 25, 2022

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8214-a07fa39 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

This was referenced Nov 25, 2022
Closed
Merged
@mokagio mokagio requested a review from a team December 2, 2022 06:00
@mokagio mokagio marked this pull request as ready for review December 2, 2022 06:00
@mokagio mokagio enabled auto-merge December 2, 2022 06:00
AliSoftware
AliSoftware approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@mokagio mokagio merged commit 0de8555 into trunk Dec 2, 2022
@mokagio mokagio deleted the mokagio/genstrings-in-ci branch December 2, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AliSoftware AliSoftware AliSoftware approved these changes

Assignees

@mokagio mokagio

Labels

category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc.

Projects

None yet

Milestone

11.6

Development

Successfully merging this pull request may close these issues.

4 participants

@mokagio @wpmobilebot @AliSoftware